Gender.js ➔ Gender - Code Metrics - Inspection of "fix copy bug" - rootsdev/gedcomx-js - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2281e8...8b163e )

by Justin

created 2016-06-06 18:01 UTC

Gender.js ➔ Gender A

↳ Parent: src/Gender.js

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	18
rs	9.2

var Conclusion = require('./Conclusion'),
    utils = require('./utils');

/**
 * A gender conclusion.
 * 
 * @constructor
 * @param {Object} [json]

 */
var Gender = function(json){
  
  // Protect against forgetting the new keyword when calling the constructor
  if(!(this instanceof Gender)){
    return new Gender(json);
  }
  
  // If the given object is already an instance then just return it. DON'T copy it.
  if(Gender.isInstance(json)){
    return json;
  }
  
  Conclusion.call(this, json);
  
  if(json){
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
    this.setType(json.type);

  }
};

Gender.prototype = Object.create(Conclusion.prototype);

Gender._gedxClass = Gender.prototype._gedxClass = 'GedcomX.Gender';

/**
 * Check whether the given object is an instance of this class.
 * 
 * @param {Object} obj
 * @returns {Boolean}
 */
Gender.isInstance = function(obj){
  return utils.isInstance(obj, this._gedxClass);
};

/**
 * Get the gender type
 * 
 * @returns {String} gender
 */
Gender.prototype.getType = function(){
  return this.type;
};

/**
 * Set the gender type
 * 
 * @param {String} gender
 * @returns {Gender} This instance
 */
Gender.prototype.setType = function(gender){
  this.type = gender;
  return this;
};

/**
 * Export the object as JSON
 * 
 * @return {Object} JSON object
 */
Gender.prototype.toJSON = function(){
  var json = Conclusion.prototype.toJSON.call(this);
  
  if(this.type){
    json.type = this.type;
  }
  
  return json;
};

module.exports = Gender;

1			var Conclusion = require('./Conclusion'),
2			utils = require('./utils');
3
4			/**
5			* A gender conclusion.
6			*
7			* @constructor
8			* @param {Object} [json]
			0 ignored issues – show Documentation introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report The parameter `[json]` does not exist. Did you maybe forget to remove this comment? Loading history...
9			*/
10			var Gender = function(json){
11
12			// Protect against forgetting the new keyword when calling the constructor
13			if(!(this instanceof Gender)){
14			return new Gender(json);
15			}
16
17			// If the given object is already an instance then just return it. DON'T copy it.
18			if(Gender.isInstance(json)){
19			return json;
20			}
21
22			Conclusion.call(this, json);
23
24			if(json){
			0 ignored issues – show Complexity Best Practice introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report There is no return statement if `json` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
25			this.setType(json.type);
			0 ignored issues – show Best Practice introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
26			}
27			};
28
29			Gender.prototype = Object.create(Conclusion.prototype);
30
31			Gender._gedxClass = Gender.prototype._gedxClass = 'GedcomX.Gender';
32
33			/**
34			* Check whether the given object is an instance of this class.
35			*
36			* @param {Object} obj
37			* @returns {Boolean}
38			*/
39			Gender.isInstance = function(obj){
40			return utils.isInstance(obj, this._gedxClass);
41			};
42
43			/**
44			* Get the gender type
45			*
46			* @returns {String} gender
47			*/
48			Gender.prototype.getType = function(){
49			return this.type;
50			};
51
52			/**
53			* Set the gender type
54			*
55			* @param {String} gender
56			* @returns {Gender} This instance
57			*/
58			Gender.prototype.setType = function(gender){
59			this.type = gender;
60			return this;
61			};
62
63			/**
64			* Export the object as JSON
65			*
66			* @return {Object} JSON object
67			*/
68			Gender.prototype.toJSON = function(){
69			var json = Conclusion.prototype.toJSON.call(this);
70
71			if(this.type){
72			json.type = this.type;
73			}
74
75			return json;
76			};
77
78			module.exports = Gender;

rootsdev / gedcomx-js

Push — master ( 2281e8...8b163e )

Gender.js ➔ Gender A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like